Allow all storage drivers to shrink volumes, like file-reflink#835
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #835 +/- ##
==========================================
- Coverage 70.46% 70.33% -0.14%
==========================================
Files 61 61
Lines 14161 14137 -24
==========================================
- Hits 9979 9943 -36
- Misses 4182 4194 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rustybird
changed the title
rustybird
force-pushed
the
shrink-volumes
branch
from
July 10, 2026 15:21
993afd2 to
5ca3b70
Compare
Contributor
Author
|
@Rudd-O: Are you sure that OpenZFS's Maybe it fails if snapshots of the zvol exist? If OpenZFS does support shrinking even then, I propose to add this commit to the PR: rustybird@shrink-volumes-zfs |
rustybird
changed the title
Contributor
Author
|
After setting up ZFS, I tested shrinking a 'zfs' driver volume and it worked fine. So I've added that commit to the PR. |
rustybird
force-pushed
the
shrink-volumes
branch
from
July 20, 2026 14:58
8a961f8 to
cee4105
Compare
This was referenced Jul 23, 2026
Open
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026072219-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests14 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 27 fixed
Unstable testsDetails
Performance TestsPerformance degradation:42 performance degradations
Remaining performance tests:69 tests
|
This was referenced Jul 23, 2026
marmarek
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar in purpose to #477, #478, #479 by @a-barinov in 2022, but with the shrinking check happening on the frontend side as suggested by @marmarek. The frontend already had such a check but only in the
qvm-volumetool; QubesOS/qubes-core-admin-client#475 centralizes this check toqubesadmin.storage.Volume.resize()so that any other callers are protected as well. (Qube Manager's qube Settings dialog /qubes-vm-settingsalso has its own logic that avoids callingresize()if it would shrink.)Closes #479